small fixes in C# solution

advent-of-craft · Jan 3, 2024 · 244e172 · 244e172
1 parent b4bd87b
commit 244e172
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/exercise/c#/Day11/Day11/RomanNumerals.cs b/exercise/c#/Day11/Day11/RomanNumerals.cs
@@ -27,7 +27,7 @@ public static class RomanNumerals
 
         public static Option<string> ToRoman(this int number) => Convert(number);
 
-        public static Option<string> Convert(int number)
+        private static Option<string> Convert(int number)
             => IsInRange(number)
                 ? ConvertSafely(number)
                 : None;

diff --git a/solution/c#/Day03/Day03.Tests/PopulationTests.cs b/solution/c#/Day03/Day03.Tests/PopulationTests.cs
@@ -1,5 +1,6 @@
 using FluentAssertions;
 using Xunit;
+using static System.Int32;
 using static Day03.PetType;
 
 namespace Day03.Tests
@@ -28,6 +29,9 @@ public void Who_Owns_The_Youngest_Pet()
         }
 
         private static int YoungestPetAgeOfThePerson(Person person) =>
-            person.Pets.MinBy(p => p.Age)?.Age ?? int.MaxValue;
+            person
+                .Pets
+                .MinBy(p => p.Age)?
+                .Age ?? MaxValue;
     }
 }
diff --git a/solution/c#/Day07/Day07/CI/Functional/Pipeline.cs b/solution/c#/Day07/Day07/CI/Functional/Pipeline.cs
@@ -7,7 +7,7 @@ public class Pipeline(IConfig config, IEmailer emailer, ILogger log)
     {
         private const string Success = "success";
 
-        public void Run(Project project)
+        public Option<PipelineContext> Run(Project project)
             => ContextFor(project)
                 .Bind(RunTests)
                 .Bind(Deploy);
@@ -77,7 +77,7 @@ private void SendEmail(String text)
             emailer.Send(text);
         }
 
-        private sealed class PipelineContext(Project project)
+        public sealed class PipelineContext(Project project)
         {
             public bool MustRunDeployment() => TestsRanSuccessfully || !HasTests;
 

diff --git a/solution/c#/Day07/Day07/CI/Pipeline.cs b/solution/c#/Day07/Day07/CI/Pipeline.cs
@@ -14,7 +14,7 @@ public void Run(Project project)
                 return;
             }
 
-            if (DunDeploymentFailed(project))
+            if (RunDeploymentFailed(project))
             {
                 SendEmail("Deployment failed");
                 return;
@@ -41,7 +41,7 @@ private bool RunTestsFailed(Project project)
             return false;
         }
 
-        private bool DunDeploymentFailed(Project project)
+        private bool RunDeploymentFailed(Project project)
         {
             if (project.Deploy() == Success)
             {

diff --git a/solution/c#/Day11/Day11/RomanNumerals.cs b/solution/c#/Day11/Day11/RomanNumerals.cs
@@ -27,7 +27,7 @@ public static class RomanNumerals
 
         public static Option<string> ToRoman(this int number) => Convert(number);
 
-        public static Option<string> Convert(int number)
+        private static Option<string> Convert(int number)
             => IsInRange(number)
                 ? ConvertSafely(number)
                 : None;