adds min/max empty lines after document start/end #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookietreiber
force-pushed
the
document/empty-lines
branch
3 times, most recently
from
5622fb9
to
4c86d3f
Compare
adrienverge
reviewed
Jul 13, 2021
There was a problem hiding this comment.
Hello Christian,
This looks good!
I have a few remarks, please see my comments below.
Also, can you add a few more test cases:
- For a document which just contains
---, nothing more? - In conjunction with
empty-lines?
For example,{empty-lines: {max: 1}, document-start: {min-empty-lines-after: 2}should report problems for\nand\n\n. - Are there other corner cases that I didn't think of?
This currently only includes the changes to document start. Will do the changes for document end and documentation later, based on your feedback.
OK
wookietreiber
force-pushed
the
document/empty-lines
branch
from
4c86d3f
to
c9c6bdc
Compare
|
@adrienverge Thanks for the review. I'm gonna do the rest of the work, likely spread over the next couple of days. When I'm done, I'm going to remove the draft status and ping you for another review (dunno if removing the draft issues a notification, maybe re-requesting a review does). |
adrienverge
reviewed
Jul 13, 2021
wookietreiber
force-pushed
the
document/empty-lines
branch
4 times, most recently
from
e7fef28
to
8d31c7d
Compare
wookietreiber
force-pushed
the
document/empty-lines
branch
from
8d31c7d
to
88d302e
Compare
wookietreiber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adrienverge What do you think?
Note: This currently only includes the changes to document start. Will do the changes for document end and documentation later, based on your feedback.
fixes #340