Support for Keras 3 #317
Support for Keras 3 #317
Conversation
Still need to fix warnings, cleanup
|
This is nearly done. Locally I have only some flakey tests related to precision (sklearn generated assertions off by 1e-8...). |
| tensorflow-cpu = {version = ">=2.12.0,<2.13.0", optional = true} | ||
| tensorflow-metal = {markers = "sys_platform == \"darwin\" and platform_machine == \"arm64\"", version = "^1.1.0"} | ||
| python = ">=3.9.0,<4" | ||
| scikit-learn = ">=1.4.1.post1" |
There was a problem hiding this comment.
This is the very latest version. Is it really necessary, or is an earlier version sufficient?
There was a problem hiding this comment.
An earlier version may suffice but given that they’ve made several breaking changes within this major version I’d like to just set it to something that works for now to save time with this update. We can always relax it later.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
==========================================
- Coverage 97.59% 96.39% -1.20%
==========================================
Files 7 7
Lines 748 722 -26
==========================================
- Hits 730 696 -34
- Misses 18 26 +8 ☔ View full report in Codecov by Sentry. |
|
📝 Docs preview for commit 418c9e1 at: https://adriangb.com/scikeras/refs/pull/317/merge/ |
No description provided.