Skip to content

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Sep 6, 2021

This patching shouldn't be needed since keras-team/keras#14748 was merged, pending keras-team/keras#15300

@stsievert
Copy link
Collaborator

Requiring a higher version of Keras/TF is not a unreasonable approach. Maybe that can be done at some point in the future.

@adriangb
Copy link
Owner Author

adriangb commented Sep 7, 2021

yep, agreed, that may be a better alternative to this PR. I think next major release may be a good candidate.

@adriangb
Copy link
Owner Author

adriangb commented Nov 9, 2021

Well I opened keras-team/keras#252 to bump the versions.
Unfortunately, this PR is still not viable because we handle 2 things here which have still not been upstreamed:

So for now I am leaning towards bumping the versions in keras-team/keras#252 and then looping back here once/if the above issues are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants