Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Allow for a custom BypassProxy class to override how a page source is fetched. #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IVLIVS-III
Copy link

This PR allows custom BypassProxies to also override the way a page is fetched, i.e. via a custom protocol or api.

Does this PR change anything for users only using defaults?

No, if you only use the default BypassProxy classes, nothing has changed.

What has changed?

While using this package, I wanted to connect to a custom proxy instance via a protocol that would require to transform the http request.
The previous implementation of BypassProxy only allowed to specify a proxyUrl but assumed that the remote proxy instance would communicate via standard http requests.

To address this use case, the implementation of fetching the corresponding pageSource of a pageUrl can now be overridden in a custom BypassProxy subclass.
However, the default implementation still assumes the remote proxy instance to communicate via basic http.

As an andditional use case: this change would also allow a custom BypassProxy to implement their own caching.

This allows custom BypassProxies to also override the way a page is fetched, i.e. via a custom protocol or api.
@IVLIVS-III
Copy link
Author

For anyone who wants to use this branch, you can use webviewx_plus instead.
All changes have been merged in there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant