Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move RELEASING.md to a GitHub wiki #3993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gdams
Copy link
Member

@gdams gdams commented Oct 11, 2024

Move RELEASING.md into a Wiki as it would be so much easier to keep up to date and in my opinion changes to it shouldn’t require a 2 person review flow

Wiki can be found at https://github.com/adoptium/temurin-build/wiki/Temurin-Release-Guide

Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

@github-actions github-actions bot added the documentation Issues that request updates to our documentation label Oct 11, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite like having the reviews so I notice when changes are made, but I appreciate that's not a compelling reason.
Since it's quite a formal process maybe there's some advantage to having it formally reviewed when changes are made. So I'll stay neutral and let two other people review this one ;-)
Good shout on making sure we don't just delete the file and replacing it with a link to the new location though.

BTW there is one part of this file that I think has some formatting oddities - if you find them while reading through the rendered output it would be good to correct them.

@judovana
Copy link
Contributor

judovana commented Oct 11, 2024 via email

@gdams
Copy link
Member Author

gdams commented Oct 11, 2024

I think there is a way to keep wiki in sources, and so to make PRs mandatory
for them, and still have wiki as read only view on them. Cant his be set up?

I guess the point I'm making is that in my opinion PRs shouldn't be mandatory, we shouldn't be adding hurdles to people who want to improve our docs. For what it's worth, Wikis do still have revision history so if we used meaningful updates this might be okay? https://github.com/adoptium/temurin-build/wiki/Temurin-Release-Guide/_history

@judovana
Copy link
Contributor

Tahts a good point. To full-fill both - no PR for doc only, and have doc change part of the PR is hard one.
I would still vote the second option. As the doc-only change can have very narrow and stright forward review. But it is narrow fight 49:51:( Good luck!

@sxa
Copy link
Member

sxa commented Oct 11, 2024

Tahts a good point. To full-fill both - no PR for doc only, and have doc change part of the PR is hard one. I would still vote the second option. As the doc-only change can have very narrow and stright forward review. But it is narrow fight 49:51:( Good luck!

Yeah same view as me then :-) Ultimately both are viable and as a "part of the release process" document I like it being under full change control but not enough to block this

The releasing doc is a bit special as it covers various areas of the project and quite often any changes aren't directly aligned with stuff in this repository as well so you can't necessarily put any code change and doc change into the same PR. And, of course, this is a doc which we frequently perform updates to for clarifications etc. independent of actual code changes to avoid any undue stress for people following the steps in here during the busy release cycles.

There may be a valid argument for using a wiki in the adoptium/temurin repository instead of in build since it's not just covering things in the build repo 🤷🏻

I agree, I'm watching the diffs too

As George says the pages still have change history, and I would strongly recommend that anyone updating this way uses the comment box at the bottom so there is a meaningful change log, similar to commit messages.

@gdams
Copy link
Member Author

gdams commented Oct 11, 2024

I can move the wiki to the adoptium/temurin repo if you'd prefer it to be located there?

@karianna karianna requested a review from sxa October 14, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues that request updates to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants