Allow UCL sign option for Windows installer #321
Conversation
Related adoptium/temurin-build#2525 Signed-off-by: Adam Brousseau <[email protected]>
|
Have tested this for the new code path on my farm. Added param to |
| @ECHO OFF | ||
| "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\x64\signtool.exe" sign -f "%SIGNING_CERTIFICATE%" -p "%SIGN_PASSWORD%" -fd sha256 -d "Adoptium" -t %%s "ReleaseDir\!OUTPUT_BASE_FILENAME!.msi" | ||
| @ECHO ON | ||
| IF "%SIGN_TOOL%" == "ucl" ( |
| ucl sign-code --file "ReleaseDir\!OUTPUT_BASE_FILENAME!.msi" -n WindowsSHA -t %%s --hash SHA256 | ||
| ) ELSE ( | ||
| @ECHO OFF | ||
| "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\x64\signtool.exe" sign -f "%SIGNING_CERTIFICATE%" -p "%SIGN_PASSWORD%" -fd sha256 -d "AdoptOpenJDK" -t %%s "ReleaseDir\!OUTPUT_BASE_FILENAME!.msi" |
There was a problem hiding this comment.
Should be Adoptium not AdoptOpenJDK?
|
What is the meaning of adding dedicated code that is not used by temurin build farm ? something like :
and sign.cmd can reuse all the parent var he want to sign |
As a philosophy, we're happy to accept changes that help other folks who use our build scripts (as long as they are not detrimental to the temurin builds). Using extensibility is a good idea here :-) |
|
@AdamBrousseau is this still required? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
|
Well we have the changes on our fork. Ideally we upstream as many of our changes as possible. Prevents merge conflicts and contributes our work back to the community. |
Related adoptium/temurin-build#2525
Signed-off-by: Adam Brousseau [email protected]