Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: improves Ant-Contrib role compatibility #3753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahdipub
Copy link

It helps improve Ant-Contrib role by replacing wget with get_url module. Also when extracing, on macos the unarchive module might fails as it asks for gtar but default macos tar is bsdtar. The workaround is to run it as command on macos machines.

Signed-off-by: [email protected]

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@karianna
Copy link
Contributor

@mahdipub linter failures

@sxa
Copy link
Member

sxa commented Sep 30, 2024

Given the comment above the line, This needs to be tested on Solaris before it can be approved.
VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

It helps improve `Ant-Contrib` role by replacing wget with get_url module. Also when extracting, on macos the `unarchive` module might fails as it asks for gtar but default macos tar is `bsdtar`. The workaround is to run it as command on macos machines.

Signed-off-by: [email protected]
@mahdipub
Copy link
Author

@mahdipub linter failures

Thanks, that's resolved.

@karianna
Copy link
Contributor

karianna commented Oct 1, 2024

Given the comment above the line, This needs to be tested on Solaris before it can be approved. VPC run at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1969/

Don't see Solaris as part of that run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants