Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add Fedora 41 40 and Ubuntu 2410 static dockerfiles #3694

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Aug 2, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3689 #3690 #3691

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Aug 2, 2024

The f39 and u1804 dockerstatic gh actions should fail as I have deleted those dockerfiles. The files changed tab suggests that I have renamed them, but Ive deleted them

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I didn't realise the F39 and U24.10 images were available. Surprised they do that without having to pull a specific tag while it's pre-release (You can tell by the PRETTY_NAME="Fedora Linux 41 (Container Image Prerelease)" or rawhide in /etc/os-release for Fedora, or PRETTY_NAME="Ubuntu Oracular Oriole (development branch)" for Ubuntu).

Was there a specific reason for bumping the version of ant in this update?

We should remember to look at switching the containers for the final ones once they are released (so perhaps we shouldn't close the related issues for those versions once we merge this)

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Aug 6, 2024

Was there a specific reason for bumping the version of ant in this update?

For fedora, it looks like weve been using 1.10.12 for a while,

RUN wget -q -O /tmp/ant.zip 'https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.12-bin.zip'
. Since I merely changed the f39 dockerfile to 40 and 41 i didnt realise there was a difference in ant versions between the fedora and ubuntu static dockerfiles. The AQA pipelines ran fine (some failures), but if youd prefer a consistent version, I can change it back to 1.10.5

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for bumping the version of ant in this update?

For fedora, it looks like weve been using 1.10.12 for a while,

RUN wget -q -O /tmp/ant.zip 'https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.12-bin.zip'

. Since I merely changed the f39 dockerfile to 40 and 41 i didnt realise there was a difference in ant versions between the fedora and ubuntu static dockerfiles. The AQA pipelines ran fine (some failures), but if youd prefer a consistent version, I can change it back to 1.10.5

I've been thinking we should consider this upgrade for a while, but we should look at doing it across the board - and since we've already been using it on Fedora for a while there's a reasonable chance it's working well enough, so I'm ok with leaving it in here for now :-)

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Haroon-Khel Haroon-Khel merged commit bfc9fcb into adoptium:master Aug 6, 2024
14 of 18 checks passed
@Haroon-Khel Haroon-Khel deleted the new.static.dockerfiles branch August 6, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants