Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Temurin build of x64/ppc64le/aarch64/s390x Linux for jdk-21+ using Adoptium gcc 11.3.0 DevKit #984

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Mar 28, 2024

Enable Temurin build of x64/ppc64le/aarch64/s390x Linux for jdk-21+ using Adoptium DevKit
release:

  • x64/ppc64le : gcc-11.3.0-Centos7.9.2009-b02
  • aarch64 : gcc-11.3.0-Centos7.6.1810-b02
  • s390x : s390x-on-s390x.RH7

aarch64 uses Centos7.6 as it is the matching latest version for RHEL7.

@andrew-m-leonard andrew-m-leonard self-assigned this Mar 28, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added jenkins-pipeline aarch ppc64le Issues that affect or relate to the ppc LINUX OS testing x64 Issues that affect or relate to the x64/x32 LINUX OS labels Mar 28, 2024
@andrew-m-leonard andrew-m-leonard changed the title Enable build x64/ppc64le/aarch64 Linux for jdk-21+ using Adoptium DevKit Enable Temurin build of x64/ppc64le/aarch64 Linux for jdk-21+ using Adoptium DevKit Mar 28, 2024
@andrew-m-leonard
Copy link
Contributor Author

run tests

@andrew-m-leonard andrew-m-leonard changed the title Enable Temurin build of x64/ppc64le/aarch64 Linux for jdk-21+ using Adoptium DevKit Enable Temurin build of x64/ppc64le/aarch64 Linux for jdk-21+ using Adoptium gcc 11.3.0 DevKit Mar 28, 2024
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to add in a --with-devkit parameter for s390x along with this too assuming some of my test runs overnight work as expected :-)

Also when adoptium/infrastructure#3488 goes in and the build images get built the same will be possible on these three platforms too.

@andrew-m-leonard
Copy link
Contributor Author

We should be able to add in a --with-devkit parameter for s390x along with this too assuming some of my test runs overnight work as expected :-)

Also when adoptium/infrastructure#3488 goes in and the build images get built the same will be possible on these three platforms too.

@sxa That's great.
Since s390x won't be downloaded from devkit-runtimes, a PR will be needed to update --use-adoptium-devkit to search in /usr/local/devkit and verify tag, ditto for picking up the local x64/ppc64le/aarch64 ones..

Lets get this merged, and I can enable the later in a new PR.

@karianna karianna requested a review from sxa April 3, 2024 10:06
@andrew-m-leonard andrew-m-leonard changed the title Enable Temurin build of x64/ppc64le/aarch64 Linux for jdk-21+ using Adoptium gcc 11.3.0 DevKit Enable Temurin build of x64/ppc64le/aarch64/s390x Linux for jdk-21+ using Adoptium gcc 11.3.0 DevKit Apr 3, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note to reviewers - the s390x naming WILL be improved later for consistency but this will allow us to get parity for now.

@andrew-m-leonard andrew-m-leonard merged commit 39a0328 into adoptium:master Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch jenkins-pipeline ppc64le Issues that affect or relate to the ppc LINUX OS testing x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants