Resolve testenv.properties "-ga" tags to the actual openjdk build tag for scm_ref check #967
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
There was a problem hiding this comment.
I'm shuddering somewhat at the amount of extra code we're adding for this, but I'll approve based on the test results so we can get the dry run pipelines initiated (To be clear I have not done a full review of the code)
I would suggest we also describe the problem that this is solving in the start of the description i.e. what fails without this.
Signed-off-by: Andrew Leonard <[email protected]>
|
/merge |
|
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
|
/approve |
1 similar comment
|
/approve |
github-actions
bot
dismissed
their stale review
Thank you @smlambert and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.
… for scm_ref check (adoptium#967) * Update release testenv jdkBranch check to resolve -ga commit Signed-off-by: Andrew Leonard <[email protected]> * Update release testenv jdkBranch check to resolve -ga commit Signed-off-by: Andrew Leonard <[email protected]> * Update release testenv jdkBranch check to resolve -ga commit Signed-off-by: Andrew Leonard <[email protected]> --------- Signed-off-by: Andrew Leonard <[email protected]>
… for scm_ref check (#967) (#968) * Update release testenv jdkBranch check to resolve -ga commit * Update release testenv jdkBranch check to resolve -ga commit * Update release testenv jdkBranch check to resolve -ga commit --------- Signed-off-by: Andrew Leonard <[email protected]>
testenv.properties branch tag contains a potential "-ga" or "-dryrun-ga" tag, eg: https://github.com/adoptium/aqa-tests/blob/2403f9f458a53d1b7c9d73c39606c5065ccbd798/testenv/testenv.properties#L20C14-L20C30
In this case we need to resolve it to the actual upstream build tag, that is specified on the pipeline scm_ref.
Without this a release pipeline will fail like:
Local tests with this PR: