Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mac x64 & aarch64 reproduciable comparison build #764

Merged
merged 7 commits into from
Aug 1, 2023

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jul 27, 2023

Close #763

Signed-off-by: Sophia Guo [email protected]

@sophia-guo sophia-guo marked this pull request as draft July 27, 2023 19:01
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@sophia-guo sophia-guo self-assigned this Jul 27, 2023
@sophia-guo sophia-guo changed the title Mac Enable mac x64 & aarch64 reproduciable comparison build Jul 27, 2023
@github-actions github-actions bot added aarch mac x64 Issues that affect or relate to the x64/x32 LINUX OS labels Jul 27, 2023
@sophia-guo
Copy link
Contributor Author

/thaw

@sophia-guo
Copy link
Contributor Author

Depends on adoptium/temurin-build#3443

@github-actions github-actions bot dismissed their stale review July 31, 2023 15:12

Pull Request unblocked - code freeze is over.

@sophia-guo sophia-guo marked this pull request as ready for review July 31, 2023 15:13
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and a rebase since this one contains former PR's code

@karianna
Copy link
Contributor

karianna commented Aug 1, 2023

Depends on adoptium/temurin-build#3443

Merged

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrew-m-leonard andrew-m-leonard merged commit c9ff44f into adoptium:master Aug 1, 2023
6 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
* Enable window-x64,ppc64le, s390x jdk17 reproducible comparison

Signed-off-by: Sophia Guo <[email protected]>

* Fix lib issues on non-linux platforms

Signed-off-by: Sophia Guo <[email protected]>

* Ensure non docker image build reproduced on different agent.

Signed-off-by: Sophia Guo <[email protected]>

* Update to temurin-build master branch

Instead of personal branch for testing

Signed-off-by: Sophia Guo <[email protected]>

* Enable window-x64,ppc64le, s390x jdk17 reproducible comparison

Signed-off-by: Sophia Guo <[email protected]>

* Enable mac reproducible comparision

Signed-off-by: Sophia Guo <[email protected]>

* Update back to default temurin-build master branch

Signed-off-by: Sophia Guo <[email protected]>

---------

Signed-off-by: Sophia Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch jenkins-pipeline mac x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enable jdk17 mac-x64 and mac aarch64 reproducible comparison build
4 participants