Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable window-x64, s390x, ppc64le reproducible comparison #757

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jul 13, 2023

jdk17 enabled.

Close #743
Close #758

Signed-off-by: Sophia Guo [email protected]

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@sophia-guo
Copy link
Contributor Author

@sophia-guo sophia-guo self-assigned this Jul 13, 2023
@sophia-guo sophia-guo changed the title Enable window reproducible comparison Enable window-x64, s390x, ppc64le reproducible comparison Jul 13, 2023
@karianna
Copy link
Contributor

Hmm, should code freeze bot not be blocking this?

@github-actions github-actions bot added ppc64le Issues that affect or relate to the ppc LINUX OS s390x Issues that affect or relate to the s390x LINUX OS x64 Issues that affect or relate to the x64/x32 LINUX OS labels Jul 18, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Instead of personal branch for testing

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo enabled auto-merge (squash) July 29, 2023 02:34
@sophia-guo sophia-guo disabled auto-merge July 29, 2023 02:34
@sophia-guo
Copy link
Contributor Author

/thaw

@github-actions github-actions bot dismissed their stale review July 31, 2023 12:41

Pull Request unblocked - code freeze is over.

@sophia-guo sophia-guo merged commit 29aea06 into adoptium:master Jul 31, 2023
6 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
* Enable windows reproduciable comparison jenkins build

Signed-off-by: Sophia Guo <[email protected]>

* Enable window-x64,ppc64le, s390x jdk17 reproducible comparison

Signed-off-by: Sophia Guo <[email protected]>

* Update to adoptium/temurin-build master

Instead of personal branch for testing

Signed-off-by: Sophia Guo <[email protected]>

---------

Signed-off-by: Sophia Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-pipeline ppc64le Issues that affect or relate to the ppc LINUX OS s390x Issues that affect or relate to the s390x LINUX OS x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
No open projects
Status: Done
3 participants