Improve resilience of MacOS Code Signing Step #751
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
|
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
The Windows jdk20 job has failed here, but the error (pasted below) appears identical to one seen 2 weeks ago here, so even if this wasn't on a totally different platform, I don't think this failure is related to this PR. |
Yes, it looks like a transient network or disk issue.. I'll try rerunning that check, but Im happy that this isn't related to this PR, as the other Mac builds worked ok. |
Convert grep string to constant, and echo max iterations
Add fail switch to curl
* Add check for codesigning process. * Add looping signing attempts * Fix extra space * Review fixes Convert grep string to constant, and echo max iterations * Add fail switch to curl Add fail switch to curl * Use constant for signing string.
Fixes Issue #596
Implements a check for each file signed in the code signing step, validates the results, and has 20 attempts with a minor pause to allow and reduce flooding the code signing service with requests.