sign node label

[cornelia247]

Parameterized the SIGN_NODE_LABEL to allow users conveniently change defaults #51

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,19"

[sophia-guo]

It is better to move this definition to the function build() to be visible to sign(), signInstaller() and probably other functions.

[sophia-guo]

context.node('eclipse-codesign') , feels this node is also used to sign jmods. @andrew-m-leonard is it good to update the line mentioned here to `context.node("${SIGN_NODE_LABEL}")?

[zdtsw]

maybe ask AdamBrousseau to take a look too, since he is the one created original issue

[zdtsw]

Suggested change

	/* groovylint-disable-next-line VariableTypeRequired */
	def nodeFilter = "${SIGN_NODE_LABEL}"
	String nodeFilter = "${SIGN_NODE_LABEL}"

[zdtsw]

@cornelia247 need a rebase first

[andrew-m-leonard]

this has been stale for over a year, converting to "draft", if no longer needed please close.