Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename argument parameters #440

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sakshi1215
Copy link
Contributor

@sakshi1215 sakshi1215 commented Oct 10, 2022

fixes #433
Signed-off-by: sakshi1215 [email protected]

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,19"

@github-actions github-actions bot added generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline labels Oct 10, 2022
@sakshi1215
Copy link
Contributor Author

Hi @zdtsw can you please review this?

Signed-off-by: sakshi1215 <[email protected]>
@sakshi1215 sakshi1215 requested review from karianna and zdtsw and removed request for karianna and zdtsw October 11, 2022 04:15
@sakshi1215
Copy link
Contributor Author

Hi @karianna @zdtsw can you please take a look again?

@zdtsw
Copy link
Contributor

zdtsw commented Oct 11, 2022

Ping @AdamBrousseau to double check if these two parameters need to be updated for your Jenkins job

@sakshi1215 sakshi1215 requested review from zdtsw and karianna and removed request for karianna and zdtsw October 11, 2022 10:01
@AdamBrousseau
Copy link
Contributor

Is there a manual update needed to job(s) or will they automatically regenerate with the updated names?

@zdtsw
Copy link
Contributor

zdtsw commented Oct 12, 2022

Is there a manual update needed to job(s) or will they automatically regenerate with the updated names?
the job should be re-generated accordingly with new parameter's name.
but if you have anything else calls such job, e.g remote trigger with parameters, that need to be updated manually.

@sakshi1215 sakshi1215 requested review from karianna and removed request for zdtsw October 12, 2022 13:29
@sakshi1215
Copy link
Contributor Author

@karianna @zdtsw @AdamBrousseau Is this good to be merged?

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a Semeru perspective.

@zdtsw
Copy link
Contributor

zdtsw commented Oct 12, 2022

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

Copy link
Contributor

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, should have considered this rename from CLEAN_WORKSPACE to CLEAN_WORKSPACE_BEFORE would require the change in the class IndividualBuildConfig, which is not in the scope of this git repo.

@zdtsw zdtsw self-requested a review October 12, 2022 16:49
@sakshi1215
Copy link
Contributor Author

sakshi1215 commented Oct 12, 2022 via email

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but needs to go in with corresponding fix in the other repo

@karianna
Copy link
Contributor

@sakshi1215
Copy link
Contributor Author

@karianna @zdtsw Here is the PR adoptium/jenkins-helper#43

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but not sure we should merge just before a release?

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakshi1215
Copy link
Contributor Author

Actually we'd need to change this as well: https://github.com/adoptium/jenkins-helper/blob/9fd063790c64a7cf2f9ee38c4bf4655f430d8be6/src/common/IndividualBuildConfig.groovy#L58

Its already done @andrew-m-leonard adoptium/jenkins-helper#43

@sakshi1215 sakshi1215 requested review from andrew-m-leonard and removed request for zdtsw October 14, 2022 09:25
@andrew-m-leonard
Copy link
Contributor

Actually we'd need to change this as well: https://github.com/adoptium/jenkins-helper/blob/9fd063790c64a7cf2f9ee38c4bf4655f430d8be6/src/common/IndividualBuildConfig.groovy#L58

Its already done @andrew-m-leonard adoptium/jenkins-helper#43

excellent

@karianna karianna marked this pull request as draft October 14, 2022 09:34
@karianna
Copy link
Contributor

Will merge with the jenkins helper fix post release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-merge-post-release generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align jenkins jobs' parameters' names
6 participants