Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up pipeline stage result setting and exception handling #1071

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Jul 4, 2024

Fixes #1068

Problem:

  • Because for several sub-jobs like "tests", we use propagate: false, the job result does not set the stage result, we currently only set the overall build result. (Note: We want propagate: false so we can run all the tests and then report all the failures, rather than exit the job at the very first failure)

This PR fixes:

  • Ensure all sub-jobs called within "stages" also set the stage result
  • Tidy up several catch(Exception) clauses that swallow exceptions, and were not setting overall build result to FAILURE
  • Add missing "sign verification" stage

Fixed tests:

  • Various x64Linux forced failures/aborts, showing correct SmokeTest stage results:
    Screenshot 2024-07-04 at 13 06 55
  • Various Mac stages, aborted/failed, all showing correct Stage results:
    Screenshot 2024-07-04 at 12 39 21

@andrew-m-leonard andrew-m-leonard self-assigned this Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard
Copy link
Contributor Author

run tests

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on these pipelines, but if this definitely works I'm delighted to approve it (And it'll be fairly obvious soon if there are any problems with it I expect)

@sxa sxa requested a review from sophia-guo July 4, 2024 12:22
@sxa
Copy link
Member

sxa commented Jul 4, 2024

Adding Sophia as a potential reviewer as she was involved in the issue referenced in the description.

@github-actions github-actions bot added the x64 Issues that affect or relate to the x64/x32 LINUX OS label Jul 4, 2024
Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-m-leonard andrew-m-leonard removed the request for review from steelhead31 July 4, 2024 14:20
@andrew-m-leonard andrew-m-leonard merged commit b575eaa into adoptium:master Jul 4, 2024
25 of 28 checks passed
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-pipeline testing x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colour of smoke test block in build pipeline does not reflect failed status correctly.
4 participants