Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'Nightly Without Publish' the default choice for openjdkNN-pipeline jobs to avoid accidental publishing #1060

Merged

Conversation

andrew-m-leonard
Copy link
Contributor

Fixes: #1059

Changed the pipeline job generation default releaseType choice to "Nightly Without Publish" to avoid accidental publishing of test builds.
Note:

@andrew-m-leonard andrew-m-leonard self-assigned this Jun 27, 2024
@github-actions github-actions bot added generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline labels Jun 27, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard
Copy link
Contributor Author

run tests

@sophia-guo sophia-guo self-requested a review June 27, 2024 13:37
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@andrew-m-leonard andrew-m-leonard merged commit 9fa9ef4 into adoptium:master Jun 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openjdkNN-pipeline builds default to "nightly" - With Publish
4 participants