Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also build jtreg version 7.4+1 #1051

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

keithc-ca
Copy link
Contributor

Needed for the head stream (Java 24), otherwise testing fails

Error: The testsuite at /home/jenkins/workspace/Grinder/aqa-tests/openjdk/openjdk-jdk/test/jdk requires jtreg version 7.4+1 or higher and this is jtreg version 7.3.1-dev+1.

See https://openj9-jenkins.osuosl.org/job/Grinder/3673/.

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nit, please change the variable to match other versions, like 7.3+1 and 7.2+1. Thanks!

tools/code-tools/jtreg.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sxa
Copy link
Member

sxa commented Jun 20, 2024

@andrew-m-leonard Is this the same linter failure that should be fixed by your recent update? I did a merge but it still seems to be failing.

@keithc-ca
Copy link
Contributor Author

I'm not sure how to interpret the log of the SHELL_SHFMT failure. It shows changes that I did not make: do they instead represent changes that are being suggested?

Signed-off-by: Keith W. Campbell <[email protected]>
@sxa
Copy link
Member

sxa commented Jun 20, 2024

I'm not sure how to interpret the log of the SHELL_SHFMT failure. It shows changes that I did not make: do they instead represent changes that are being suggested?

There's a reasonable chance it's nothing to do with your PR ... And yes I completely agree that the error need is somewhat lacking in comprehensibility ...

I'm quite tempted to just merge this but since Andrew had looked at the linter this week it would be good to have his ok first.

@andrew-m-leonard
Copy link
Contributor

I suspect there's some new SHELL_SHFMT syntax in super-linter 6.6.0. I'll look at shaell linter'ing separately

@andrew-m-leonard andrew-m-leonard merged commit 701ada8 into adoptium:master Jun 21, 2024
6 of 7 checks passed
@keithc-ca keithc-ca deleted the jtreg_7.4+1 branch June 21, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants