Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jdk23 and add jdk24 pipeline configurations #1047

Merged
merged 7 commits into from
Jun 21, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Jun 19, 2024

  • Add new jdk24 pipeline configuration files, now that jdk23 has branched.
  • Add jdk23_release.groovy, and remove obsolete arm32, win32, and remove riscv from evaluation.

Note: Had to fix build_base_file.groovy, as the pr-tester is failing due to missing logic for AQAvit archiving when no AQA tests are run...

@andrew-m-leonard andrew-m-leonard self-assigned this Jun 19, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@andrew-m-leonard
Copy link
Contributor Author

run tests

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hold off on this until #1045 is merged, and then rebase on that change to ensure that the AIX changes are included here.

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@sxa
Copy link
Member

sxa commented Jun 20, 2024

AIX PRs merged, so if you can add in the label changes to the new versions in this PR that would be appreciated :-)

@andrew-m-leonard
Copy link
Contributor Author

run tests

@andrew-m-leonard
Copy link
Contributor Author

AIX PRs merged, so if you can add in the label changes to the new versions in this PR that would be appreciated :-)

@sxa updated..

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@andrew-m-leonard andrew-m-leonard merged commit cca48ca into adoptium:master Jun 21, 2024
7 of 8 checks passed
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants