Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive all taps after parallel run #1041

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

sophia-guo
Copy link
Contributor

Access archived tap file from jobs archive directory

Only archive if tests are enabled.

Fix #1039

Access archived tap file from jobs archive directory

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo marked this pull request as draft May 29, 2024 17:30
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo
Copy link
Contributor Author

${env.JENKINS_HOME} can't be accessible directly due to security constraints.

using currentBuild.rawBuild.getArtifactsDir().toString(), Scripts not permitted to use method hudson.model.Run getArtifactsDir. Administrators can decide whether to approve or reject this signature.

So I think final easy way is to copyArtifacts in pipeline job itself.

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Jun 3, 2024

@sophia-guo sophia-guo marked this pull request as ready for review June 3, 2024 13:02
@sophia-guo
Copy link
Contributor Author

@andrew-m-leonard

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@karianna karianna merged commit 49d73e2 into adoptium:master Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline build fails if no tests run due to archive tap file failure
3 participants