Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests with known issues #3231

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Exclude tests with known issues #3231

merged 1 commit into from
Jan 21, 2022

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jan 18, 2022

Signed-off-by: Sophia Guo [email protected]

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sophia-guo !

@llxia
Copy link
Contributor

llxia commented Jan 18, 2022

close #3230

If this PR is going to close #3230, then we should not reference #3230 in the disable comment.

<comment>eclipse-openj9/openj9/issues/14165,https://github.com/adoptium/aqa-tests/issues/3230</comment>

This creates a loop where a disabled test is referencing a closed issue. It will create problem for disabled test pipeline in the future.

<versions>
<version>8</version>
<version>11</version>
</versions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary exclusion? If so, please use disable feature and reference the open issue. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick answer is we don't know. @joeyleeeeeee97 could probably confirm that adoptium/aqa-systemtest#474

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophia-guo could we use disable feature and reference adoptium/aqa-systemtest#474 for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a good approach as this is a temporary exclusion based on joeyleeeeeee97's reply

@smlambert
Copy link
Contributor

and I guess this is really only going to exclude in nightlies running off master... after we review the other triaged test, we could consider pushing exclusions to the v0.8.0-release branch

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sophia-guo

@llxia llxia merged commit 1a95f8a into adoptium:master Jan 21, 2022
sophia-guo added a commit that referenced this pull request Jan 21, 2022
@sophia-guo sophia-guo deleted the updates branch May 13, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants