Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: make SharedProps compatible with inertia usePage" #53

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

Julien-R44
Copy link
Member

This PR broke InferPageProps. For example :

export default function Home(props: InferPageProps<TestsController, 'login'>) {
  props
  // ^? { [x: string]: never; [x: number]: never; }
}

props will always be equal to { [x: string]: never; [x: number]: never; } no matter what we do.

cc @Barabasbalazs

@Julien-R44 Julien-R44 merged commit d7cdf3a into 3.x Jan 5, 2025
14 checks passed
@Julien-R44 Julien-R44 deleted the revert-50-fix-sharedprops-typing-in-config branch January 5, 2025 17:16
@Barabasbalazs
Copy link
Contributor

@Julien-R44 thanks for the heads up. I will look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants