Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): rename identifier to defineIdentifier and add IfMissing… #44

Merged
merged 1 commit into from
Mar 19, 2025
Merged

feat(parser): rename identifier to defineIdentifier and add IfMissing… #44

merged 1 commit into from
Mar 19, 2025

Conversation

RomainLanz
Copy link
Member

Hey there! 👋🏻

This PR renames Env.idenfitifer to Env.defineIdentifier and add a Env.defineIdentifierIfMissing variant.

This variant will allow us to define basic identifier like base64 and file directly from this package.

@thetutlage
Copy link
Member

Looks great. Should we document these methods in the docs?

@RomainLanz
Copy link
Member Author

Yes, PR will be send to change the following section:

🔗 https://docs.adonisjs.com/guides/getting-started/environment-variables#using-identifiers-for-interpolation

@thetutlage thetutlage merged commit 526ce63 into 6.x Mar 19, 2025
10 of 14 checks passed
@thetutlage
Copy link
Member

👍

@RomainLanz RomainLanz mentioned this pull request Mar 19, 2025
Merged
@RomainLanz RomainLanz deleted the feat/defineIdentifier branch March 19, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomainLanz @thetutlage