Fix incorrectly bypassing default value on get() caused by undefined
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcppman
force-pushed
the
reprod-env-default
branch
from
27d58a9 to
de602d0
Compare
resolves adonisjs#42: When an env value was undefined and set to a value, then manually set to undefined again, env.get('VAR', 'DEFAULT') would not return the correct default value.
jcppman
force-pushed
the
reprod-env-default
branch
from
de602d0 to
47f3402
Compare
NakatoMu
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#42
❓ Type of change
📚 Description
Resolves an edge case #42.
When an env value was undefined and set to a value, then manually set to
undefinedagain,env.get('VAR', 'DEFAULT')will not return the correct default value.
📝 Checklist