.get defaultValue is bypassed when env was set to undefined

[jcppman]

Edited/20250129

• added reproduction repo
• modified reproduction steps

Package version

6.1.1

Describe the bug

When an env variable is cleared by executing env.set("MY_VAR", undefined) or process.env.MY_VAR = undefined, env.get("MY_VAR", "DEFAULT") will return undefined.

This is kind of a rare usage but it is very useful for testing how adonis configuration react to env var changes.

Reproducing steps

1. ensure originally process.env.MY_VAR is undefined
2. env.set('MY_VAR', 'new value')
3. env.set('MY_VAR', undefined)
4. assert(env.get('MY_VAR', "DEFAULT"))

Expected behavior

env.get("MY_VAR", "DEFAULT") should still return "DEFAULT"

Actual behavior

env.get("MY_VAR", "DEFAULT") returns undefined

Reproduction repo

https://github.com/jcppman/adonis-env/tree/reprod-env-default

[thetutlage]

Can you please create failing test for this? Because as per this logic https://github.com/adonisjs/env/blob/6.x/src/env.ts#L121-L124 the default value should be returned.

[jcppman]

please refer to the testcase added here

jcppman@246e08b

[jcppman]

spotted a potential fix. created a PR

[github-actions]

This issue has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still need help on this issue

[github-actions]

This issue has been automatically closed because it has been inactive for more than 4 weeks. Please reopen if you still need help on this issue