Feat: Add support for horizontal orientation to ListLayout delegate
#8533
+184
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to layout-orientation
…ayout-orientation
|
@LFDanLu Would you be so kind to issue a build for this PR? I'm going insane because of a bug with virtualized dnd, which I can't seem to get rid of locally, even after reverting all changes and clearing caches. I would really like to know whether the issue exists on remote 😅 |
5 tasks
nwidynski
commented
Jul 12, 2025
|
|
||
| constructor(ref: RefObject<HTMLElement | null>) { | ||
| constructor(ref: RefObject<HTMLElement | null>, orientation?: Orientation) { |
There was a problem hiding this comment.
Not entirely happy with having to pass this here, but I couldn't think of any reliable alternative. I guess we could do something similar to the drop target delegate and place this information in a data attribute, but is this really preferable?
nwidynski
commented
Jul 12, 2025
Comment on lines
-184
to
-189
| let keyboardDelegate = new ListKeyboardDelegate({ | ||
| collection, | ||
| disabledKeys: selectionManager.disabledKeys, | ||
| disabledBehavior: selectionManager.disabledBehavior, | ||
| ref | ||
| }); |
There was a problem hiding this comment.
Was there a reason for this delegate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for horizontal orientations to
ListLayoutin preparation for aCarouselPR 👍 I can also try and expand the scope of this change toGridLayout, after getting the initial thoughts of the team. Currently I'm not entirely sure how a horizontal grid would be laid out (e.g. drop indicators horizontal or vertical?).✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: