Skip to content

Fix: circular dependency in @internationalized/date #8001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

luixo
Copy link
Contributor

@luixo luixo commented Mar 28, 2025

Closes a relevant issue

The copy and copyDateTime seem to be unused and not exported outside of the package.
They also break Vercel deployments of the projects that use @internationalized/date for some reason (probably connected with the heroui issue), that's why I made the fix.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

All existing tests should pass.

@snowystinger
Copy link
Member

Thanks for the pr, you'll need to sign the CLA before we can review it https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement. Thanks!

@luixo luixo force-pushed the fix/date-circular-dependency branch from 2b20b9e to fea83af Compare March 31, 2025 11:18
@luixo
Copy link
Contributor Author

luixo commented Mar 31, 2025

Thanks for the pr, you'll need to sign the CLA before we can review it

Done

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, they aren't being used elsewhere
I'm not sure why we have these, @devongovett do you recall? it looks like it wasn't used in the PR it was introduced in either 0e528a5#diff-d2fb7ef0cb40b4a7bc8b2eb2beddd89028c1426dd3c3a704c1d8894ec13f2294

@snowystinger snowystinger added the small review Easy to review PR label Apr 7, 2025
@LFDanLu LFDanLu added this pull request to the merge queue Apr 11, 2025
Merged via the queue into adobe:main with commit 7e8b1f9 Apr 11, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small review Easy to review PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency warnings when building
3 participants