-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Feat: Form attribute of button with type submit #7892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suyash5053
wants to merge
13
commits into
adobe:main
Choose a base branch
from
suyash5053:1456-form-attribute-for-submit-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d8d190b
feat: form attribute to buttons of type submit
suyash5053 81cb3fb
Merge branch '1456-form-attribute-for-submit-button' of https://githu…
suyash5053 db0f84c
implementing the form prop to the right place
suyash5053 3aef255
removed the type based prop adding, and added a form prop
suyash5053 b9b1ee8
Merge branch 'main' into 1456-form-attribute-for-submit-button
suyash5053 a5d0cd6
Update packages/@react-types/button/src/index.d.ts
snowystinger fb3714d
Update packages/@react-types/button/src/index.d.ts
snowystinger 5000104
test case for form prop
suyash5053 570eda4
Merge branch 'main' into 1456-form-attribute-for-submit-button
suyash5053 95cd684
Merge branch 'main' into 1456-form-attribute-for-submit-button
suyash5053 7a32b5f
Merge branch 'main' into 1456-form-attribute-for-submit-button
suyash5053 15c7fae
Merge branch 'main' into 1456-form-attribute-for-submit-button
snowystinger 008b41d
Update packages/@react-spectrum/button/test/Button.test.js
snowystinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the test is failing, can you see why the form attribute isn't making it onto the button? it's likely being filtered out somewhere