working branch for supporting windows contributors #6313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a windows developer, I am unable to install RSP and contribute.
Steps to reproduce:
I have found a number of issues, mostly around the
build-icons
step.after much trial and error (mostly error), i have found that the culprit is that we are specifying
--extensions '.cjs,.js'
when we build each of the icon bundles. for some reason,babel-node
does not see this as a valid extension, and will actually simply ignore *.js anyway. Furthermore, this invalid extension value causes all other cli arguments to be ignored, and thuspresets @babel/env
is also ignored. this is where we get the cjs import transform from. Causing the above errors.after that i had an error starting story book, due to improper path separators. The launch failed in git bash. This is because in git bash we need forward slashes, not back slashes.
path
is not aware of this nuance and incorrectly gives us backslashes on every shell that detects aswin32
. I have used the packageis-mingw
to solve this in our preview.js.summarization of steps taken:
babel-node --extensions '.cjs,.js'
- babel automatically will use .cjs, and for some reason this was causing babel to ignore all other cmd line args, including--presets @babel/env
, which is where we get the cjs import transform on mac/linuxCloses (#6314)
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: