-
Notifications
You must be signed in to change notification settings - Fork 66
MCP Server #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trieloff
wants to merge
7
commits into
main
Choose a base branch
from
mcp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MCP Server #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new MCP command with support for tools to manage AEM development servers. - Added logging functionality with an in-memory logger to capture log entries. - Implemented tools for starting (`up`), stopping (`stop`), and retrieving logs (`logs`) from the MCP server. - Updated CLI to include the new `mcp` command alongside existing commands.
- Introduced a new `resetLogs` function to clear the log buffer, primarily for testing purposes. - Added comprehensive unit tests for the MCP logger, covering various logging functionalities, including filtering and context handling. - Created new test files for MCP command and tools, ensuring robust testing of command structure and execution. - Enhanced existing tests to validate logging behavior and error handling in tools.
- Updated the stop tool to correctly handle string values for ports, ensuring compatibility with user input. - Enhanced error handling in the stop tool, including cases where no servers are running or when specified servers are not found. - Added comprehensive tests to cover various scenarios, including stopping multiple servers, handling errors during stop operations, and ensuring proper logging of errors. - Updated copyright year in the test file to reflect the current year.
- Introduced a new section detailing how to use AEM as an MCP server with compatible tools. - Provided command usage for integrating AEM with IDEs and interacting with AI assistants for server management.
Fun POC. |
- Added 'trace' as a new log level in the in-memory logger. - Updated log level enumeration in the logs tool to include 'trace'. - Enhanced unit tests to cover logging at the 'trace' level and added filtering tests for log levels, including 'trace'. - Adjusted existing tests to account for the new log level and ensure accurate log message assertions.
- Added functionality to the MCPCommand to check for a valid git repository in specified workspace paths and the current directory. - Implemented logic to change the working directory to the first valid git repository found, improving server initialization. - Removed outdated test for readline initialization in the run method to streamline test coverage.
This PR will trigger a minor release when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small MCP server that can be used to start, stop, and retrieve logs from a local
AEM development server. Check the readme for details on running it, although to run it from a this
branch, you'll need
npx -y github:adobe/helix-cli#mcp mcp
. Yep, that'smcp
twice.