This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
[REVIEW ONLY] Enable Cookies #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,16 @@ ClientHandler::ClientHandler() | |||
| callbackId = 0; | |||
| CreateProcessMessageDelegates(process_message_delegates_); | |||
| CreateRequestDelegates(request_delegates_); | |||
|
|
|||
| // Default schemes that support cookies. | |||
| cookieable_schemes_.push_back("http"); | |||
There was a problem hiding this comment.
is there any reason to store this information in a member var? seems like we just need to create the array, add the schemes we want cef to store cookies for and call CefCookieManager::SetSupportedSchemes and we're done. Or does the CefCookieManager not make a copy of the schemes in the array for some reason?
|
I am trying to get cookies from server in client app that is running on bracket but cookie only comes in response header (set-cookie). How to set it to browser cookie ?? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for adobe/brackets#8582