Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify color #363

Merged
merged 8 commits into from
Jul 30, 2024
Merged

chore: unify color #363

merged 8 commits into from
Jul 30, 2024

Conversation

fkakatie
Copy link
Member

update color (background and text, including links) to align with s2 design

Test URLs:

Before: https://main--aem-boilerplate--adobe.hlx.live/
After: https://unify-color--aem-boilerplate--adobe.hlx.live/

Copy link

aem-code-sync bot commented May 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 24, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie fkakatie requested a review from rofe May 24, 2024 20:23
Copy link
Contributor

@rofe rofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSI check no longer shows 100 for accessibility due to lack of contrast...
https://pagespeed.web.dev/analysis/https-unify-color--aem-boilerplate--adobe-hlx-live/mspnh18ogw?form_factor=mobile

@rofe
Copy link
Contributor

rofe commented May 25, 2024

Is S2 compliance really a requirement for the boilerplate?

@fkakatie
Copy link
Member Author

Is S2 compliance really a requirement for the boilerplate?

Not at all. I'm only pulling values from it in an attempt to set some sort of visual consistency across boilerplate > block collection.

@rofe
Copy link
Contributor

rofe commented May 29, 2024

I think having 3 x 100 in PSI out of the box should be considered a higher priority than visual consistency.

@fkakatie
Copy link
Member Author

fkakatie commented Jun 6, 2024

Screenshot 2024-06-06 at 10 44 27 AM

What am I missing here? Discrepancy between aem-code-sync report and PSI report: https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Funify-color--aem-boilerplate--adobe.hlx.live%2F

styles/styles.css Outdated Show resolved Hide resolved
@rofe
Copy link
Contributor

rofe commented Jun 7, 2024

What am I missing here? Discrepancy between aem-code-sync report and PSI report:

I clicked re-run PSI check, now it's showing the same.

@fkakatie fkakatie merged commit bb8e1bd into main Jul 30, 2024
4 checks passed
@fkakatie fkakatie deleted the unify-color branch July 30, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants