Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify font #362

Merged
merged 4 commits into from
Jul 30, 2024
Merged

chore: unify font #362

merged 4 commits into from
Jul 30, 2024

Conversation

fkakatie
Copy link
Member

  • update font styles (size, weight, and line height) to align with s2 design

⚠️ potentially controversial: added a new font for the heading-font-family variable. boilerplate uses Roboto, which is already a departure from s2. most projects have multiple fonts, so including an example on how to properly configure those might be useful.

Test URLs:

Copy link

aem-code-sync bot commented May 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 24, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rofe
Copy link
Contributor

rofe commented May 25, 2024

Is S2 compliance really a requirement for the boilerplate?

@fkakatie
Copy link
Member Author

Is S2 compliance really a requirement for the boilerplate?

Not at all. I'm only pulling values from it in an attempt to set some sort of visual consistency across boilerplate > block collection.

@fkakatie fkakatie merged commit 516d856 into main Jul 30, 2024
4 checks passed
@fkakatie fkakatie deleted the unify-font branch July 30, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants