Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept, actual macro name may be changed in final version. But the general idea is to simplify the way logging is implemented. Namely it requires developer to specify
__FILE__
and__LINE__
macros manually. In this PR i introducelogger_log_fileinfo
function similar tologger_log
with the only difference that it accepts extra file and line number arguments. Alsolog
macro was introduced which automatically puts file and line number in the function call. This design particularly allows to uselog
without any format arguments like this:I left the original
logger_log
func calls in the places where__FILE__
and__LINE__
hadn't been used. Probably it makes sense to make them uniform and use the newlog
macro instead.