Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartling translations are completed for commit e27a4b6d44607d0b26525d2b429bf62669f9745d from main #1229

Merged

Conversation

smartling-github-connector[bot]
Copy link
Contributor

Please review this translation pull request. The relevant Smartling translation job is available here - https://dashboard.smartling.com/app/accounts/aaa8fc6f/account-jobs/7fd223df3:ws4zzqz5vrgw
Here is a link to the source commit which triggered translation - e27a4b6

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 5:05pm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to this PR change, but I created a Jira to fix a minor typo in this article: https://adjustcom.atlassian.net/browse/FECORE-541?atlOrigin=eyJpIjoiZWM3ZDA0OGQzMWU5NDRjNzk0M2YzMzZmZThjODI0ZDMiLCJwIjoiaiJ9

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can fix it in the scope of this PR, what do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that would be great if you can!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the format! Looks great

Copy link
Collaborator

@tomokogoto1 tomokogoto1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bzavhorodskyi I went through all files in this PR and looked good! Please go ahead and deploy.

@bzavhorodskyi bzavhorodskyi merged commit 913df6a into main Jan 20, 2025
6 checks passed
@bzavhorodskyi bzavhorodskyi deleted the smartling-translation-completed-ws4zzqz5vrgw-from-main branch January 20, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants