feat: store server config in a database. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seilagamo
force-pushed
the
store-server-config-in-db
branch
2 times, most recently
from
91e9f9c to
dc4771f
Compare
seilagamo
force-pushed
the
store-server-config-in-db
branch
from
dc4771f to
2ece918
Compare
manelmontilla
suggested changes
Mar 20, 2023
manelmontilla
suggested changes
Mar 29, 2023
pkg/secrets/secrets.go
Outdated
| return Credentials{}, err | ||
| } | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
The condition of this if branch can't never be true, as there is already a guard for err not being nil above.
There was a problem hiding this comment.
Fixed in commit 91f6d4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes: