Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prevent label clicks and keypresses from changing [aria-disabled] inputs (fixes #623) #624

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Fix: Prevent label clicks and keypresses from changing [aria-disabled] inputs (fixes #623) #624

merged 3 commits into from
Feb 11, 2025

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 6, 2025 •
edited
Loading

fixes #623

Fix

  • Prevent label clicks and key presses from changing [aria-disabled] inputs
  • Move aria-disabled handling into its own controller.

@oliverfoster oliverfoster self-assigned this Feb 6, 2025
joe-replin
joe-replin approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@joe-replin joe-replin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in multiple builds including vanilla. Works as intended. Thank you so much.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst this resolves the issue for label clicks, I'm still able to make a selection via keypress. Tested with voiceOver on Mac Safari.

@oliverfoster
Copy link
Member Author

@kirsty-hames Would you mind giving that a whirl please?

@oliverfoster oliverfoster changed the title Fix: Prevent label clicks from changing [aria-disabled] inputs (fixes #623) Fix: Prevent label clicks and keypresses from changing [aria-disabled] inputs (fixes #623) Feb 11, 2025
kirsty-hames
kirsty-hames approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oliverfoster. 1fd669d works as expected. Tested with voiceOver Safari on Mac.

@oliverfoster oliverfoster merged commit 0fda594 into master Feb 11, 2025
@oliverfoster oliverfoster deleted the issue/623 branch February 11, 2025 15:42
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@semantic-release-bot
Chore(release): 6.60.6
3daaae6 
## [6.60.6](v6.60.5...v6.60.6) (2025-02-11)

### Fix

* Prevent label clicks and key presses from changing [aria-disabled] inputs (fixes #623) (#624) ([0fda594](0fda594)), closes [#623](#623) [#624](#624)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.60.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@joe-replin joe-replin joe-replin approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aria-disabled=true input still receives label click to trigger on change
4 participants
@oliverfoster @kirsty-hames @joe-replin @cahirodoherty-learningpool