Skip to content

Commit

Permalink
Fix: Prevent label clicks from changing [aria-disabled] inputs (fixes #…
Browse files Browse the repository at this point in the history
  • Loading branch information
oliverfoster authored Feb 6, 2025
1 parent 3cec6f1 commit 8320723
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion js/a11y/browserFocus.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ export default class BrowserFocus extends Backbone.Controller {
if (!event.isTrusted) return;
const $element = $(event.target);
// search element and parents for aria-disabled - see https://github.com/adaptlearning/adapt_framework/issues/3097
const isAriaDisabled = $element.closest('[aria-disabled=true]').length === 1;
// search closest 'for' element for aria-disabled - see https://github.com/adaptlearning/adapt-contrib-core/issues/623
const $closestFor = $element.closest('[for]');
const isAriaDisabled = $element.closest('[aria-disabled=true]').length === 1 ||
($closestFor.length && $(`#${$closestFor.attr('for')}`).is('[aria-disabled=true]'));
if (isAriaDisabled) {
event.preventDefault();
event.stopImmediatePropagation();
Expand Down

0 comments on commit 8320723

Please sign in to comment.