ci(baselines): Bump baselines to Python 3.10#6194
Open
danieljanes wants to merge 2 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the minimum Python version requirement from 3.8/3.9 to 3.10 across multiple baseline projects. The changes ensure consistency in Python version support by removing older version classifiers and updating tooling configurations.
Changes:
- Removed Python 3.7, 3.8, and 3.9 from package classifiers
- Updated minimum Python version in dependencies to >=3.10.0
- Updated Black and Ruff target versions to only include py310 and py311
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| baselines/statavg/pyproject.toml | Updated Black and Ruff target versions to py310 |
| baselines/flwr_baselines/pyproject.toml | Updated classifiers, dependencies, and Black target version to Python 3.10+ |
| baselines/floco/pyproject.toml | Updated Black and Ruff target versions to py310 |
| baselines/fedrep/pyproject.toml | Updated Black and Ruff target versions to py310 |
| baselines/fedprox/pyproject.toml | Updated Black and Ruff target versions to py310 |
| baselines/fedpft/pyproject.toml | Updated classifiers, dependencies, and tooling to Python 3.10+ |
| baselines/feddebug/pyproject.toml | Updated classifiers, dependencies, and tooling to Python 3.10+ |
| baselines/fedbn/pyproject.toml | Updated Black and Ruff target versions to py310 |
| baselines/fedavgm/pyproject.toml | Updated classifiers, dependencies, and tooling to Python 3.10+ |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| python = ">=3.10.0, <3.12.0" # don't change this | ||
| flwr = { extras = ["simulation"], version = "1.5.0" } | ||
| hydra-core = "1.3.2" # don't change this | ||
| torch = {url = "https://download.pytorch.org/whl/cu118/torch-2.6.0%2Bcu118-cp310-cp310-linux_x86_64.whl#sha256=715d3b039a629881f263c40d1fb65edac6786da13bfba221b353ef2371c4da86"} |
There was a problem hiding this comment.
This torch wheel URL is hardcoded to cp310 (Python 3.10) but the project now supports Python 3.10 and 3.11. Consider using a version-agnostic approach or documenting that Python 3.11 users need a different wheel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.