Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(baselines) Upgrade FedBN Baseline to new flwr format #5115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maddox-j
Copy link
Contributor

Issue

Description

This PR upgrades the existing FedBN baseline from the previous flwr format to the new version.
Specifically:

  1. Removed hydra library dependency
  2. Adapted existing configuration files into pyproject.toml format
  3. Use of Flower ClientApp and ServerApp
  4. Kept manual handling of dataset (discussion points at the end of the PR).
  5. Saving of results to disk by overloading the Server class definition.
  6. Update README.md with steps to run baseline simulation through flwr run .
  7. Result visualisation with Jupyter Notebook.
  8. Ensured stateful clients through using the ParametersRecord in the client Context.

Related issues/PRs

#4952 contains a related discussion about leaving the manual handling of the dataset.

Proposal

Explanation

This PR upgrades the existing FedBN baseline from the previous flwr format to the new version.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant