feat(framework) One gRPC request per Message in GrpcDriver
#5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
gRPC has a hard limit on the size of a single gRPC message. If we push or pull multiple
Messages in a singlePushMessagesRequestorPullMessagesResponse, we gonna hit the limit very easily. For example, given the 2GB limit, if the driver pushes 100 messages in a single request, the actual limit for each message will be just 20 MB.However, sending each message sequentially can be pretty slow. And thus we can accelerate it via multi-threading.
What it does?
Send each
Messagein a separate gRPC request.