-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(examples) Update custom-mods
example
#5063
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jafermarq! It's a very timely one. Only minor comments.
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Thanks for the review ! I've pushed the missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @jafermarq! Last batch of comments, mainly nits.
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Make it use
flwr new
. Added some quality improvements to how W&B mode works