Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples) Update custom-mods example #5063

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jafermarq
Copy link
Contributor

Make it use flwr new. Added some quality improvements to how W&B mode works

@jafermarq jafermarq marked this pull request as ready for review March 11, 2025 21:19
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jafermarq! It's a very timely one. Only minor comments.

jafermarq and others added 2 commits March 12, 2025 07:00
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
@jafermarq
Copy link
Contributor Author

Thanks for the PR @jafermarq! It's a very timely one. Only minor comments.

Thanks for the review ! I've pushed the missing __init__.py.

Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @jafermarq! Last batch of comments, mainly nits.

jafermarq and others added 2 commits March 12, 2025 08:56
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants