Example for Secure Aggregation with low-level API #4967
+119
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
reviewed
Feb 28, 2025
Comment on lines
+61
to
+74
| # Example `on_send`/`on_receive`/`on_stage_complete` callback functions | ||
| def on_send(msgs: Iterable[Message], state: SecAggPlusAggregatorState) -> None: | ||
| """Intercept messages before sending.""" | ||
| log(INFO, "Intercepted messages before sending.") | ||
|
|
||
|
|
||
| def on_receive(msgs: Iterable[Message], state: SecAggPlusAggregatorState) -> None: | ||
| """Intercept reply messages after receiving.""" | ||
| log(INFO, "Intercepted reply messages after receiving.") | ||
|
|
||
|
|
||
| def on_stage_complete(success: bool, state: SecAggPlusAggregatorState) -> None: | ||
| """Handle stage completion event.""" | ||
| log(INFO, "Handled stage completion event.") |
There was a problem hiding this comment.
What do you see these functions to be useful for (in addition to logging purposes)?
There was a problem hiding this comment.
I think it would be a bit useful for some advanced user to adjust the protocol, but generally it's more for me to implement things like weighted averaging based on the original SecAggPlusInsAggregator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.