Breakage due to changes of (internal) dependencies. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vscode-yaml-languageservice uses internal API of vscode-json-languageservice and is broken due to changes of these types. See microsoft/vscode-json-languageservice#18 The quick fix is to depend on a fixed version of vscode-json-languageservice. In the long term we should work on making real API in vscode-json-languageservice
|
Note: New APIs have been added to the JSON language service allow the YAML language service to create a JSONDocument from a custom ASTNode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscode-yaml-languageservice uses internal API of vscode-json-languageservice and is broken due to changes of these types.
See microsoft/vscode-json-languageservice#18
The quick fix is to depend on a fixed version of vscode-json-languageservice.
In the long term we should work on making real API in vscode-json-languageservice