Skip to content

Commit

Permalink
Refactor build-push-image action.yaml: Update image URI value and tags
Browse files Browse the repository at this point in the history
  • Loading branch information
adamlahbib committed Nov 16, 2024
1 parent 6d641cb commit 0e5e8ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/actions/build-push-image/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ inputs:
outputs:
image:
description: 'Docker image URI'
value: ${{ steps.image-uri.outputs.tag }}:latest
value: ${{ steps.image-uri.outputs.tag }}:${{ inputs.stage }}-${{ github.sha }}

runs:
using: 'composite'
Expand Down Expand Up @@ -58,6 +58,6 @@ runs:
with:
push: true
file: ${{ inputs.dockerfile }}
tags: ${{ steps.image-uri.outputs.tag }}:latest, app-${{ inputs.stage }}:${{ github.sha }}
tags: ${{ steps.image-uri.outputs.tag }}:latest, ${{ steps.image-uri.outputs.tag }}:${{ github.sha }}, ${{ steps.image-uri.outputs.tag }}:${{ inputs.stage }}-${{ github.sha }}
cache-from: type=gha
cache-to: type=gha,mode=max
2 changes: 1 addition & 1 deletion terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ resource "aws_eks_node_group" "eks_nodes" {

launch_template {
id = aws_launch_template.eks_launch_template.id
version = "$Latest"
version = "1" # static version instead of $Latest to avoid it be considered a change at every apply
}

scaling_config {
Expand Down

0 comments on commit 0e5e8ac

Please sign in to comment.