Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some cleanup on pin-names:
SPICE_xxx
toSPCE_xxx
(Pimoroni calls their connector SP/CE)SPI
(board.SPI()
throwsNotImplementedError
anyways)GPxx
names since all pins are normal GPIOs as wellSPICE_TX
andSPICE_RX
. RX/TX pin names are UART-related on other boards. Here, they are only inclusive names for MOSI/MISO. It turns out thatSPICE_TX
is an UART-RX and vice versa. So to avoid confusion, I removed the names.Adding a
board_spi_obj
(thus preventing theNotImplementedError
) would be possible, but I don't think this makes sense. The SP/CE connector lacks a DC-pin and busy-pin. So to drive a SPI-screen, it is better to create an SPI object without MISO and use the pin for DC.I would even suggest to remove
SCK
,MISO
andMOSI
as well. They are already defined asSPCE_SCK
(and so on). The pure names suggest that there is something like a default SCK/MISO/MOSI on the Pico, which is not the case and is not implemented for other Pico-boards.@ZodiusInfuser: maybe you could chime in and share your opinion regarding the pin-names