Add support for ADI MAX32690 microcontroller #9667

Brandon-Hurst · 2024-09-27T15:36:06Z

Description

Add support for 2 boards: MAX32690EVKIT and AD-APARD32690-SL.

Status

At the moment, this port only includes digitalio in addition to the supervisor and USB workflow required to get CircuitPython functioning. Pinouts listed are currently just the MCU pins; happy to change as needed to better match any requirements for form factor or pin function. I plan to follow this up with a busio PR soon, but will be more tied up in the next couple months. Still happy to make changes as needed to this PR though.

USB Endpoint Enumeration Change

There is a small important bit I had to change to the way CircuitPython handles settings up USB Endpoints:

TUSB has some devices (such as MAX32) which are not capable of having full-duplex endpoints. This is true for a few devices besides MAX32, but also for MAX32 (in particular a lot of others share the same IP).
There is a #define for TUD_ENDPOINT_ONE_DIRECTION_ONLY accounted for by TinyUSB, but not by the way CircuitPython initializes an endpoint on these devices. The change itself is very minimal -- it just increments the endpoint after setting up either an IN our OUT instead of both to an endpoint pair. I made it for all device classes and it should cover all cases for other devices as well.

Many thanks to @tannewt and @dhalbert for the help :)

tannewt

Thanks for the new port! I'm excited to try it. I've added a few comments. Nothing major.

ports/analog/Makefile

ports/analog/boards/apard32690/README.md

ports/analog/boards/apard32690/board.c

ports/analog/boards/apard32690/pins.c

ports/analog/boards/max32690evkit/board.c

ports/analog/common-hal/digitalio/DigitalInOut.c

ports/analog/mpconfigport.h

ports/analog/supervisor/port.c

(mp_obj_t)&fat_vfs_getreadonly_obj);'

clear any pending interrupt flag

Work around an sdk bug

fix os.uname() values for rp2350

Correct `ble_serial_connected()` when BLE workflow was never started

remove 'mp_obj_property_t' usage remains

Currently translated at 32.5% (325 of 1000 strings) Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/fil/

…quest Avoid crashing when printing DeepSleepRequest objects

Translations update from Hosted Weblate

Add MakerGo C6 SuperMini

This puts the error messages back like they were, leaving the null pointer dereference fixes in place.

…be usable. - Had to adjust some shared modules to account for MAX32 devices not supporting IN/OUT endpoints on the same EP #

… Fixed bugs with Internal Flash filesystem. Files now write & read back correctly. - Added copyright headers for all files.

…h in microcontroller/Pin.c

…re. Added priority to remaining TODOs (low)

…h interrupt_after_ticks. - Move LED inidcator to STATUS_LED code.

… GPIO Port 4 (different on MAX32690). - Added MCR defs to max32_port.h.

…or Sphinx docs.

…g pullup/pulldown

…tion settings.

…verriding to Makefile flash-msdk task

tannewt self-requested a review September 27, 2024 16:38

tannewt requested changes Sep 27, 2024

View reviewed changes

diamant3 and others added 28 commits October 4, 2024 11:01

remove 'mp_obj_property_t' usage remains

7e72009

fix formatting

d976f83

use 'mp_obj_property_getter_t' type

d5d4026

add static 'MP_PROPERTY_GETTER(fat_vfs_readonly_obj,

a19ddf5

(mp_obj_t)&fat_vfs_getreadonly_obj);'

add static to 'extmod/vfs_fat.c: fat_vfs_label_obj'

2a85894

Merge pull request adafruit#9680 from jepler/rp2-pio-background-dma-bug

321d6e9

clear any pending interrupt flag

Merge pull request adafruit#9682 from jepler/rp2350-sdk-bug-workaround

11d4bce

Work around an sdk bug

Merge pull request adafruit#9683 from dhalbert/raspberrypi-os-uname

a693bd7

fix os.uname() values for rp2350

Merge pull request adafruit#9679 from dhalbert/fix-ble-serial-check

7f14b9c

Correct `ble_serial_connected()` when BLE workflow was never started

Merge pull request adafruit#9684 from diamant3/adafruitGH-9660

54d4827

remove 'mp_obj_property_t' usage remains

Doc and error messaging changes

cca8d00

Merge remote-tracking branch 'origin/audio_effects' into audio_effects

d2e5173

Improved documentation

146c13e

Add MakerGo C6 SuperMini

1e4fbd9

Removed utils.h which was not required

0fa3cd8

Translated using Weblate (Filipino)

0ced12c

Currently translated at 32.5% (325 of 1000 strings) Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/fil/

Do power led

e9bb5cf

Change the comment type

1c58d7c

Fix about incorrectly recalculating delay

48e1327

Avoid crashing when printing DeepSleepRequest objects

125faae

remove deprecated call in doc setup

5b77156

Merge pull request adafruit#9692 from jepler/fix-printing-deepsleepre…

ef70b7b

…quest Avoid crashing when printing DeepSleepRequest objects

Merge remote-tracking branch 'origin/main'

b694388

Merge pull request adafruit#9688 from weblate/weblate-circuitpython-main

6a007ef

Translations update from Hosted Weblate

Merge pull request adafruit#9687 from bill88t/c6supmini

fe20582

Add MakerGo C6 SuperMini

revert usb.core.Device error message changes

08bc84b

This puts the error messages back like they were, leaving the null pointer dereference fixes in place.

Enable for all 2350 boards

af947a5

epaperdisplay: fix delay when two_byte_sequence_length is true

af7d8b7

Brandon-Hurst and others added 30 commits November 11, 2024 16:54

- Fixed USB endpoint descriptor problems. All USB classes should now …

b19f8a2

…be usable. - Had to adjust some shared modules to account for MAX32 devices not supporting IN/OUT endpoints on the same EP #

- Fixed USB issues. REPL & CIRCUITPY: drive now function correctly! -…

6691655

… Fixed bugs with Internal Flash filesystem. Files now write & read back correctly. - Added copyright headers for all files.

Added digitalio module.

298bce3

Added max32690 EVKIT board & changed APARD board to apard32690

8e2ff56

Reordered mpconfigport.mk; replaced MXC_SYS includes with max32_port.…

a491986

…h in microcontroller/Pin.c

Moved GPIO ports to board.c to make it easy to add boards in the futu…

66d2c95

…re. Added priority to remaining TODOs (low)

Updated USB PID for max32690evkit

f90f390

Formatting fixes missed by local pre-commit runner

9a96603

Add "analog" to shared_bindings_matrix.py

c11fac8

More pre-commit fixes.

a911626

Manual pre-commit fix for all requisite files.

806ef63

Manual pre-commit fix for last delinquent file

ba08379

- Move SysTick init from board_init to port_init. - Fix RTC issue wit…

79a9ad7

…h interrupt_after_ticks. - Move LED inidcator to STATUS_LED code.

- Changed board.c to match silkscreen. - Added digitalio handling for…

6c99e4e

… GPIO Port 4 (different on MAX32690). - Added MCR defs to max32_port.h.

pre-commit formatting fixes

fbffbfd

more pre-commit fixes

af96599

final pre-commit fix

41ee086

Fix CI run issues with docs & tlsf submodule

509239a

- Add elf target for CI build. - Add ports/analog/README to toctree f…

77a4f75

…or Sphinx docs.

Update msdk submodule to clear nvic/dma warnings

dfca771

Remove dma_revb.c from Makefile

d406a74

Add CONFIG_TRUSTED_EXECUTION_SECURE macro to Makefile

83ffc64

Add open-drain to digitalio + Resolve some issues with GPIO4 & settin…

b50c31b

…g pullup/pulldown

Pre-commit formatting fix

b84170d

Pre-commit formatting fix

fd15266

Fix optimization settings for non-debug builds

b0bd662

Enabled SysTick interrupt for time.sleep to work. Cleaned up optimiza…

ff2bdc5

…tion settings.

Remove FIXME comments from supervisor/port.c. Changes were tested.

689cf8b

- Add instructions for ARM Cross Toolchain to README. - Add OpenOCD o…

2bb66a4

…verriding to Makefile flash-msdk task

Resolve merge conflicts with remote in Makefile & README

435ecc6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ADI MAX32690 microcontroller #9667

Add support for ADI MAX32690 microcontroller #9667

Brandon-Hurst commented Sep 27, 2024 •

edited

Loading

tannewt left a comment

Add support for ADI MAX32690 microcontroller #9667

Are you sure you want to change the base?

Add support for ADI MAX32690 microcontroller #9667

Conversation

Brandon-Hurst commented Sep 27, 2024 • edited Loading

Description

Status

USB Endpoint Enumeration Change

tannewt left a comment

Choose a reason for hiding this comment

Brandon-Hurst commented Sep 27, 2024 •

edited

Loading