espressif: Enable the _eve module

[chungsoftvn-tuannguyen]

Enable the _eve module for espressif mcu.

[dhalbert]

To do this in general, do it in ports/espressif/mpconfigport.mk. Right now you've enabled it on some boards, but many are omitted. But it might not fit on some boards.

[dhalbert]

We have enabled this on certain boards by request, but it's not enabled by default in general.

[chungsoftvn-tuannguyen]

The switch must be in the boards/[board_name]/mpconfigport.mk file because:

1. Some boards are already equipped with a custom display (such as adafruit_feather_esp32s2_tft) without EVE chip, so user may not need _eve module there (Because _eve module only works with an EVE chip).
2. Some boards fail to compile when the _eve module is enabled (Build CI jobs) due to an error: Too little flash (Such as adafruit_feather_esp32c6_4mbflash_nopsram).

[dhalbert]

I understand. How did you choose which boards to add _eve_ to?

[chungsoftvn-tuannguyen]

I have selected all the boards from vendors: Adafruit, Arduino, Espressif, and AI-Thinker because these are development boards, allowing users to try them with an EVE module.

[dhalbert]

Thanks for the discussion. I've noted one board that is designed for driving other displays and shouldn't be on this list.

@tannewt how do you feel about this addition?

[dhalbert]

This board is already for driving a particular kind of display, so let's not add _eve to this.

[chungsoftvn-tuannguyen]

I removed this line from espressif/boards/adafruit_qualia_s3_rgb666/mpconfigboard.mk.
The configuration is refactored to espressif/mpconfigport.mk at commit 8d57867

[tannewt]

@tannewt how do you feel about this addition?

I'm happy to see eve enabled on espressif.

I agree with you that the enabling should be refactored into mpconfigport. The other thing to consider is whether it is on by default for future boards.

1. Some boards are already equipped with a custom display (such as adafruit_feather_esp32s2_tft) without EVE chip, so user may not need _eve module there (Because _eve module only works with an EVE chip).

Disable EVE on these boards instead. There is likely other display functionality disabled too.

2. Some boards fail to compile when the _eve module is enabled (Build CI jobs) due to an error: Too little flash (Such as adafruit_feather_esp32c6_4mbflash_nopsram).

Do something similar to:

circuitpython/ports/espressif/mpconfigport.mk

Lines 132 to 137 in ca2a24e

	# No room for _bleio on boards with 4MB flash
	ifeq ($(CIRCUITPY_ESP_FLASH_SIZE),4MB)
	CIRCUITPY_BLEIO ?= 0
	else
	CIRCUITPY_BLEIO ?= 1
	endif

That way you can set a reasoned default for future boards.

[chungsoftvn-tuannguyen]

I have enabled the _eve module by default for all ESP boards with a flash size greater than 2MB as of commit 8d57867. For boards that already have a display, I have still enabled the _eve module for future use.

[tannewt]

Looks good! Thank you!

stale