Only do package update, no system upgrade

[timonsku]

The guides already say to to an upgrade before even running this script and the way this works right now it just hangs for a long time without any feedback for sometimes 10-20 minutes.
This is I think not a very good UX. See this issue on more reasoning: #174
The default nature of upgrading all the system packages is I think a bit too many changes than one would expect from installing a python package.

[makermelissa]

The reason we have the upgrade is so we can have users having issues run the script to make sure they are up to date. I think we could add a parameter to skip the upgrade step. Would that be an acceptable compromise?

[timonsku]

I think without feedback of the process I would not have it in there. On the weekend I ran it on a fresh Pi and apparently there was some error in the process and it was just stuck forever but you never really know.

If you think its really necessary to upgrade the whole system and not just the relevant packages I would have it ask during the process if you want to upgrade or not and if possible forward the output of apt to the user so they see what is going on and have them confirm individual things. At the moment it would just wipe all config changes a user may have made because of the -y option.

Otherwise I would maybe put in a notice but leave out the system upgrade for the user to run manually.

[makermelissa]

Ok, yeah. Asking in the process is another great option.

[makermelissa]

I updated the code to ask to update the packages rather than foregoing them altogether.

[timonsku]

definitely better but can adafruit_shell maybe forward the stdin and stdout so that the -y option can be ommited?
Again I think overwriting custom configurations of system packages would be bad especially for beginner who might not know that an upgrade can do that.
Either way I think seeing the output of the upgrade process would be a must have, it can easily happen that the command gets stuck on something causing the script to never return after starting the upgrade as has happened to me before while using it.

[makermelissa]

Kind of going through some of these that have been sitting awhile. regarding your last comment, adding stdin to python_shell is a great idea. I think it currently only does stdout and stderr. However, this might take some experimenting so it stays in order.

[makermelissa]

I just released a new version of python_shell and have fixed the run_command. Forwarding stdin wasn't necessary, but it now works interactively and doesn't lock up.